[#4708] improvement(client-java/server): Add implementations for the getFileLocation interface in Java Client / Server
#4858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 23, 2024 14:04
xloya
force-pushed
the
add-impl-for-get-file-location
branch
2 times, most recently
from
342fe36 to
839c2ed
Compare
xloya
force-pushed
the
add-impl-for-get-file-location
branch
2 times, most recently
from
18427c1 to
664ac5a
Compare
xloya
force-pushed
the
add-impl-for-get-file-location
branch
2 times, most recently
from
c9e386c to
3fe438f
Compare
|
@jerryshao Hi, this PR is ready for review, please take a look when you have time, thanks. |
xloya
changed the title
getFileLocation interfaces in Java Client / ServergetFileLocation interface in Java Client / Server
xloya
force-pushed
the
add-impl-for-get-file-location
branch
from
3fe438f to
f3227ad
Compare
jerryshao
reviewed
Sep 5, 2024
|
|
||
| CallerContext callerContext = CallerContext.CallerContextHolder.get(); | ||
| Map<String, String> queryParams = Maps.newHashMap(); | ||
| queryParams.put("subPath", subPath); |
There was a problem hiding this comment.
I think maybe we should encoding the subPath to avoid supported chars in the URL.
jerryshao
reviewed
Sep 5, 2024
| queryParams.put("subPath", subPath); | ||
| FileLocationResponse resp = | ||
| restClient.get( | ||
| formatFilesetRequestPath(fullNamespace) + "/" + ident.name() + "/" + "fileLocation", |
There was a problem hiding this comment.
Is it better to add the th subPath into the URL, not a queryParam?
There was a problem hiding this comment.
Hi, I prefer to use the queryParams for the following reasons:
- Currently other similar GET APIs pass parameters in the form of queryParams, like
RelationalTable.listPartitions(); - I looked at the APIs of other commercial products, such as the REST API of Databricks' DBFS, and they also pass these parameters through queryParams: https://docs.databricks.com/api/workspace/dbfs/read;
- In the unit test, I tried to directly splice the URL, but it seems that the test framework cannot mock the request, so I guess some frameworks may not recognize the method of directly splicing parameters to the URL.
jerryshao
reviewed
Sep 5, 2024
| throw new UnsupportedOperationException("Not implemented"); | ||
| // The constraints of the name spec may be more strict than underlying catalog, | ||
| // and for compatibility reasons, we only apply case-sensitive capabilities here. | ||
| return dispatcher.getFileLocation(normalizeCaseSensitive(ident), subPath); |
There was a problem hiding this comment.
I would suggest split the core part logic into another PR. In this PR, we only focus on client and server side API. Don't make the PR too big, which is hard to review.
There was a problem hiding this comment.
Done, this PR has been split to only include changes with the Java Client and Server.
xloya
force-pushed
the
add-impl-for-get-file-location
branch
from
659f7af to
5edebdc
Compare
jerryshao
reviewed
Sep 6, 2024
| CallerContext callerContext = CallerContext.CallerContextHolder.get(); | ||
|
|
||
| Map<String, String> params = new HashMap<>(); | ||
| params.put("subPath", RESTUtils.encodeString(subPath)); |
There was a problem hiding this comment.
I would suggest we don't use camel style for param here "subPath" and path "fileLocation", how about "sub_path" and "location"?
xloya
force-pushed
the
add-impl-for-get-file-location
branch
from
ac84d2e to
3b36e37
Compare
jerryshao
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the implementations for
getFileLocationinterfaces in Java Client / Server.Why are the changes needed?
Fix: #4708
How was this patch tested?
Add some UTs and ITs.